Skip to main content

How to comment when modifying standard code [AX 2012]

I have seen many ways of modifying standard code and how commenting is done. The best practice is to make as little change as possible or as little impact to the standard solution as possible. Otherwise, making it stand out and the next person can clearly see the difference between standard code and custom code.

Looking at how the Feature pack incorporates the Extension model is very interesting.

See the screenshot below. You can see how the standard code is commented out with the <SYS> tag. Then the changes are added with their tag <PSA> or <RETAIL> as illustrated in the screenshot below.

clip_image002

Now if you look at the compare, it stands out. If for some reason you had to revert your custom code back to the original. You just delete your code between your tags and uncomment the <SYS> tags.

Compare2012-06-12_1002

On msdn there is a best practice on how to do code commenting.

http://msdn.microsoft.com/en-us/library/cc967435.aspx

It clearly says:

Do not use multi-line syntax /* … */ for comments. The single-line syntax // … is preferred even when a comment spans multiple lines.

Obviously, Microsoft developers have found that using /*…*/ in this case resulted in better readable code.

I would be interested to hear other developers thoughts on this topic.

Labels:

Popular posts from this blog

Approve Workflow via email using template placeholders #Dyn365FO

Dynamics 365 for Finance and Operations has placeholders which can be inserted into the instructions. Normally you would want this to show up in the email that is sent. One of the most useful ones is the URL link to the exact record that you are approving. In the workflow configurations use the placeholder and build up your message. Towards the end it has workflow specific ones. The URL token is %Workflow.Link to web% . For the technical people the token is replaced in this class WorkflowDocumentField. This is what I inserted into my email template. <BODY> subject: %subject% <BR> message: %message% <BR> company: %company% <BR> for: %for% <BR> </BODY> Should look like this. The final result looks like this. If you debug these are the place holders that are put together.
Read more

AX - How to use Set and SetEnumerator

The Set class is used for the storage and retrieval of data from a collection in which the values of the elements contained are unique and serve as the key values according to which the data is automatically ordered. You can create a set of primitive data types or complex data types such as a Class, Record or Container. Below is sample of a set of records. static void _Set(Args _args) {     CustTable       custTable;     Set             set = new Set(Types::Record);     SetEnumerator   setEnumerator;     ;     while select custTable     {         if (custTable && !set.in(custTable))         {             set.add(custTable);         }     }     if (!set.empty())     {    ...
Read more

Purchase requisition – Price

The price fields on the purchase requisition are non-editable for catalogue items. It is expected that a trade agreement be created. The price fields are only editable for these conditions: Form is opened view AP -> Periodic -> Purchase Requisition -> All purchase requisition, or Line type is “Non-catalogue item”, or User is task owner. Ie. The task is assigned to the user. In other words he/she maybe the purchaser that gets the price. User is approval owner. Ie. The approval is assigned to the user. In other words he/she maybe the manager that approves the final requisition. For catalogue items on the purchase requisition line can only select between the vendor directly associated with the item and the cheapest vendor as found through the purchase price trade agreements. If another vendor is requested the vendor can be blanked and the user can enter a “Proposed vendor” in the proposed vendor field on the general tab page for the purchase requisition line.   NOTE: ...
Read more